Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Android doesn't handle adding and removing views in parallel very well. If a view is removed while a different test triggers a layout then you hit an NRE exception because the FrameLayout iterates all of its children inside
OnLayout
I opted for using a
SemaphoreSlim
here instead of addingCollection
because we use thisAttachAndRun
in a lot of places. We'd probably have to add everything toCollection
to make it work that way.